Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entering the password after the recovery words #6930

Closed
yahiheb opened this issue Dec 21, 2021 · 5 comments · Fixed by #8867
Closed

Entering the password after the recovery words #6930

yahiheb opened this issue Dec 21, 2021 · 5 comments · Fixed by #8867

Comments

@yahiheb
Copy link
Collaborator

yahiheb commented Dec 21, 2021

The password/passphrase is also called a 13th/25th word, it is an extension to the recovery words and in most bitcoin wallets a user is asked to enter it after the recovery words. We should do the same.

@soosr
Copy link
Collaborator

soosr commented Dec 21, 2021

I thought we are doing this

@soosr
Copy link
Collaborator

soosr commented Dec 21, 2021

Yes, it seems to me we do exactly like that.

I have entered the 12 rec words then press enter, and the password dialog popped.

@yahiheb
Copy link
Collaborator Author

yahiheb commented Dec 21, 2021

Yes, it seems to me we do exactly like that.

I have entered the 12 rec words then press enter, and the password dialog popped.

Not when we generate a new wallet.

@danwalmsley
Copy link

This would require @zkSNACKs/code-team to do some huge refactor.

We need the password so we can generate the wallet, to get the seed words.

we cant have the password afterwards.

Feel free to re-open if you think its important.

@yahiheb
Copy link
Collaborator Author

yahiheb commented Jan 5, 2022

This would require @zkSNACKs/code-team to do some huge refactor.

I don't think it requires a lot of change.

We need the password so we can generate the wallet, to get the seed words.

we cant have the password afterwards.

I don't think that is how it works, first we get the seed words, then we can add a password, and with those two sources of entropy we generate a wallet.

This is how Wasabi works: after generating the mnemonics the user can provide a password that is used as 13rd word (as described in bip 39) and as encryption password (as described in bip38). With the mnemonics + password the extended seed is derived.

Source

IMO this is an important UX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants