Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable label editing #8719

Open
BTCparadigm opened this issue Jul 14, 2022 · 4 comments
Open

Enable label editing #8719

BTCparadigm opened this issue Jul 14, 2022 · 4 comments

Comments

@BTCparadigm
Copy link
Collaborator

BTCparadigm commented Jul 14, 2022

General Description

Currently, there is no way to edit labels in the UI, other than for unused addresses. Wasn't this was possible in 1.0?
Reasoning in docs:
"This is useful when you have generated a receiving address with a specific label, but then the cause for receiving has changed."
Or you find out that more than the originally labeled entities that know, that this address belongs to you.
https://docs.wasabiwallet.io/FAQ/FAQ-UseWasabi.html#how-can-i-change-the-observers-of-my-receive-address

Correction, it wasn't possible in 1.0.
https://docs.wasabiwallet.io/FAQ/FAQ-UseWasabi.html#how-can-i-edit-the-observers-of-my-address-after-a-transaction-has-gone-through

But should it be in 2.0?

@MaxHillebrand
Copy link
Collaborator

In 1.0 you could also only edit unused address labels.

This would be a nice feature, but I believe it's difficult to do, there were some arguments against it in the past I don't remember.

@BTCparadigm
Copy link
Collaborator Author

BTCparadigm commented Jul 15, 2022

Found this huge old thread where 2 users voiced that they would like to edit labels after address have been used. Both valid use cases.
Didn't see a refute for editing, other than

Thus we cannot add an edit label option for the coins in a way you imagine. It would be something like "edit the last transaction label".

From @molnard and that sounds fine IMHO.

@yahiheb
Copy link
Collaborator

yahiheb commented Jul 15, 2022

Found this huge old thread where 2 users voiced that they would like to edit labels after address have been used. Both valid use cases.

The link is wrong.

@soosr
Copy link
Collaborator

soosr commented Jul 18, 2022

I think he meant #2455

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants