Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider switching the client to full-RBF #9041

Closed
lontivero opened this issue Sep 1, 2022 · 5 comments
Closed

Consider switching the client to full-RBF #9041

lontivero opened this issue Sep 1, 2022 · 5 comments
Assignees

Comments

@lontivero
Copy link
Collaborator

Bitcoin core is moving to change the way the RBF transactions are treated because the are some hypothetical situations where opt-out transactions can be used to deny propagation of multiparty transactions like our coinjoins.

Currently Wasabi client only allow replacement of transactions which opted-in BIP125 but it would be convenient to review this.

@lontivero lontivero self-assigned this Oct 28, 2022
@petertodd
Copy link

Also along these lines, it could be good to change the coinjoin transactions to opt-in to RBF via BIP-125. That'll make sure you've got all the necessary infrastructure to deal with double-spends of coinjoin inputs.

@lontivero
Copy link
Collaborator Author

it could be good to change the coinjoin transactions to opt-in to RBF via BIP-125

Sadly it's not so easy to do because clients build the coinjoin transaction by themselves and then everybody should upgrade at the same time. It could be possible to have some kind of activation date after what users have to upgrade but it is not cool.

Anyway, RBF (full or opted-in via 125) is something we need to implement a more effective DoS prevention mechanism.

@molnard molnard added this to the v2.0.7 milestone Feb 24, 2024
@lontivero
Copy link
Collaborator Author

First step in this direction: #12301

@molnard molnard removed this from the v2.0.7 milestone Mar 13, 2024
@MaxHillebrand
Copy link
Collaborator

MaxHillebrand commented Apr 1, 2024

TODO: client local full node use full-RBF

@molnard
Copy link
Collaborator

molnard commented Apr 16, 2024

Closed by #12644

@molnard molnard closed this as completed Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants