Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VDG] Make coinjoin settings less hidden #9432

Closed
MaxHillebrand opened this issue Oct 31, 2022 · 12 comments · Fixed by #12694
Closed

[VDG] Make coinjoin settings less hidden #9432

MaxHillebrand opened this issue Oct 31, 2022 · 12 comments · Fixed by #12694
Assignees
Milestone

Comments

@MaxHillebrand
Copy link
Collaborator

The coinjoin profile settings (red coin isolation, anonscore target etc) are too much hidden.

Figure out how to make them more accessible.

@soosr
Copy link
Collaborator

soosr commented Nov 2, 2022

Since the beginning, my idea was to have it accessible from MusicBox. It is time to implement it #8849 (comment).

@turbolay
Copy link
Collaborator

turbolay commented Nov 3, 2022

We discussed about this with @soosr because an user asked instructions to find cj settings.
It's clear that there is a real issue here, and the MusicBox idea #8849 (comment) is an interesting and cheap way to solve this.

However, it feels too crowded because of the LED auto-start indicator
What is the point of the indicator? It's redundant with what's actually written in the MusicBox.
If you have CJ auto-enabled and it will start soon it will be written in the MB anyway.
What about removing it?

It would look like this with the parameters icon:
image

@soosr
Copy link
Collaborator

soosr commented Nov 3, 2022

We discussed about this with @soosr because an user asked instructions to find cj settings. It's clear that there is a real issue here, and the MusicBox idea #8849 (comment) is an interesting and cheap way to solve this.

However, it feels too crowded because of the LED auto-start indicator What is the point of the indicator? It's redundant with what's actually written in the MusicBox. If you have CJ auto-enabled and it will start soon it will be written in the MB anyway. What about removing it?

It would look like this with the parameters icon: image

cACK for top right setting icon.
cACK for removing the LED, no one uses it.
+1 I would also remove the CJ setting from the ... menu as it make much more sense in the MusicBox.

@MaxHillebrand
Copy link
Collaborator Author

in the music box where the wasabi logo is, put the icon of the privacy profile, make it clickable and show the other options. This way user can switch profile directly in the music box.

the custom strategy can be the wasabi logo.

@soosr
Copy link
Collaborator

soosr commented Nov 21, 2022

in the music box where the wasabi logo is, put the icon of the privacy profile, make it clickable and show the other options. This way user can switch profile directly in the music box.

the custom strategy can be the wasabi logo.

FTR, some sketch up is coming for this, do not start implementing anything yet.

@yahiheb
Copy link
Collaborator

yahiheb commented Jan 14, 2023

This issue should be prioritized because many people find it difficult to access the coinjoin settings.
Another user feedback regarding this:

Not so user friendly. I'm experienced and with version 2, it took me a long time to find the coinjoin privacy settings. They are hidden behind 3 dots in the middle of the right side of the screen of the wallet. Not intuitive.

https://twitter.com/deefouren/status/1614335584335429632

@turbolay
Copy link
Collaborator

turbolay commented Jan 14, 2023

However, it feels too crowded because of the LED auto-start indicator
What is the point of the indicator? It's redundant with what's actually written in the MusicBox.

First UX feedbacks conclusions from @sannydayX confirmed that this indicator only brings confusion

@sannydayX
Copy link

sannydayX commented Jan 15, 2023

Yes that indicator is also confusing, like many other things in regards to coinjoin. Please don’t star implementing things randomly. There are indeed many uasability issues with the coinjoin, but it needs to be thought out properly as a whole and ideally conduct another user testing session focused just on coinjoin to come up with a good solution. This is a pretty big topic.

@stale
Copy link

stale bot commented Mar 19, 2023

This has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 19, 2023
@soosr soosr removed the stale label Mar 20, 2023
@soosr soosr self-assigned this Apr 24, 2023
@soosr
Copy link
Collaborator

soosr commented Apr 26, 2023

So this issue has been moved back from UX to UI board, but I still think it is more like UX stuff, like how to access the settings. So pinging @editwentyone @nopara73 and asking for opinions.

I would add a 3 dot button in the top right of MusicBox as it usually indicates "Others". That button would open a submenu where we could add the Coinjoin settings.

And in the future it would be also helpful for coinjoin related things like:

@editwentyone
Copy link

Right now its more an UX problem to solve.

I wouldn't add a shortcut to conjoin strategy, what needs to be done is consolidate everything into a "wallet settings" and clearly distinguish between "application settings"

suggestion is incoming

@soosr
Copy link
Collaborator

soosr commented Mar 18, 2024

Spec

  • Replace the LED indicator with a ... button.

I would add a 3 dot button in the top right of MusicBox as it usually indicates "Others". That button would open a submenu where we could add the Coinjoin settings.

And in the future it would be also helpful for coinjoin related things like:

Image
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants