Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy tile suggestions #9543

Closed
yahiheb opened this issue Nov 15, 2022 · 7 comments · Fixed by #12575
Closed

Privacy tile suggestions #9543

yahiheb opened this issue Nov 15, 2022 · 7 comments · Fixed by #12575
Assignees
Labels
Milestone

Comments

@yahiheb
Copy link
Collaborator

yahiheb commented Nov 15, 2022

  • When the balance is zero the privacy tile displays 100% which is the misleading/unnecessary information.
    How about displaying - or something similar instead of 100%?
  • Show the privacy tile for the watch-only and hardware wallets to fill the empty space in the main view which is ugly IMO.
@yahiheb yahiheb added the UI label Nov 15, 2022
@MaxHillebrand
Copy link
Collaborator

afaik, the plan is to hide the privacy tile if balance is zero.

@yahiheb
Copy link
Collaborator Author

yahiheb commented Nov 15, 2022

It got closed #9435

@MaxHillebrand
Copy link
Collaborator

It got closed #9435

I think that was a confusion, the intent was to clean up the many open PRs in the repo.

@soosr
Copy link
Collaborator

soosr commented Nov 16, 2022

I agree with @yahiheb on we should not hide the tile. It is simply because we are already struggling to fill the space on the dashboard and we all remember the PR that simplified the dashboard by removing the tiles, it looked shit, so hiding the tiles probably not the way we should go.

How about displaying - or something similar instead of 100%?

This is a good idea, I like it.

@stale
Copy link

stale bot commented Jan 16, 2023

This has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 16, 2023
@yahiheb yahiheb removed the stale label Jan 16, 2023
@stale
Copy link

stale bot commented Mar 19, 2023

This has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 19, 2023
@yahiheb yahiheb removed the stale label Mar 19, 2023
@stale
Copy link

stale bot commented Jun 10, 2023

This has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants