[VDG] Update to Avalonia 11 #10423
Merged
[VDG] Update to Avalonia 11 #10423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 17, 2023
MarnixCroes
reviewed
May 23, 2023
There was a problem hiding this comment.
Can't build with Qubes OS 4.1, debian 11 template. (no issues running current master)
Exception type: Tmds.DBus.Protocol.DBusException
Message: org.freedesktop.DBus.Error.ServiceUnknown: The name org.kde.StatusNotifierWatcher was not provided by any .service files
Stack Trace: at Tmds.DBus.Protocol.DBusConnection.MyValueTaskSource`1.System.Threading.Tasks.Sources.IValueTaskSource.GetResult(Int16 token)
at Tmds.DBus.Protocol.DBusConnection.CallMethodAsync(MessageBuffer message)
at Tmds.DBus.Protocol.Connection.CallMethodAsync(MessageBuffer message)
at Avalonia.FreeDesktop.DBusTrayIconImpl.CreateTrayIcon() in /_/src/Avalonia.FreeDesktop/DBusTrayIconImpl.cs:line 124
at System.Threading.Tasks.Task.<>c.<ThrowAsync>b__128_0(Object state)
at Avalonia.Threading.SendOrPostCallbackDispatcherOperation.InvokeCore() in /_/src/Avalonia.Base/Threading/DispatcherOperation.cs:line 392
at Avalonia.Threading.DispatcherOperation.Execute() in /_/src/Avalonia.Base/Threading/DispatcherOperation.cs:line 262
at Avalonia.Threading.Dispatcher.ExecuteJob(DispatcherOperation job) in /_/src/Avalonia.Base/Threading/Dispatcher.Queue.cs:line 117
at Avalonia.Threading.Dispatcher.ExecuteJobsCore() in /_/src/Avalonia.Base/Threading/Dispatcher.Queue.cs:line 148
at Avalonia.Threading.Dispatcher.Signaled() in /_/src/Avalonia.Base/Threading/Dispatcher.Queue.cs:line 128
at Avalonia.X11.X11PlatformThreading.CheckSignaled() in /_/src/Avalonia.X11/X11PlatformThreading.cs:line 119
at Avalonia.X11.X11PlatformThreading.RunLoop(CancellationToken cancellationToken) in /_/src/Avalonia.X11/X11PlatformThreading.cs:line 192
at Avalonia.Threading.DispatcherFrame.Run(IControlledDispatcherImpl impl) in /_/src/Avalonia.Base/Threading/DispatcherFrame.cs:line 117
at Avalonia.Threading.Dispatcher.PushFrame(DispatcherFrame frame) in /_/src/Avalonia.Base/Threading/Dispatcher.MainLoop.cs:line 53
at Avalonia.Threading.Dispatcher.MainLoop(CancellationToken cancellationToken) in /_/src/Avalonia.Base/Threading/Dispatcher.MainLoop.cs:line 80
at Avalonia.Controls.ApplicationLifetimes.ClassicDesktopStyleApplicationLifetime.Start(String[] args) in /_/src/Avalonia.Controls/ApplicationLifetimes/ClassicDesktopStyleApplicationLifetime.cs:line 122
at Avalonia.ClassicDesktopStyleApplicationLifetimeExtensions.StartWithClassicDesktopLifetime(AppBuilder builder, String[] args, ShutdownMode shutdownMode) in /_/src/Avalonia.Controls/ApplicationLifetimes/ClassicDesktopStyleApplicationLifetime.cs:line 215
at WalletWasabi.Fluent.Desktop.WasabiAppExtensions.<>c__DisplayClass0_0.<RunAsGuiAsync>b__0() in WalletWasabi.Fluent.Desktop/Program.cs:line 175
at WalletWasabi.Daemon.WasabiApplication.RunAsync(Func`1 afterStarting) in WalletWasabi.Daemon/WasabiAppBuilder.cs:line 67
at WalletWasabi.Fluent.Desktop.WasabiAppExtensions.RunAsGuiAsync(WasabiApplication app) in WalletWasabi.Fluent.Desktop/Program.cs:line 155
at WalletWasabi.Fluent.Desktop.Program.Main(String[] args) in WalletWasabi.Fluent.Desktop/Program.cs:line 64
Inner Exception:
Reported AvaloniaUI/Avalonia#11494 |
wieslawsoltes
commented
Jun 5, 2023
…out to hide and button Click event is not processed
We need to update later Avalonia.Controls.TreeDataGrid to stable, but rc2.2 should be api compatible
Partially fixed after 72c2bca Still labels and indicators have some issue |
MaxHillebrand
suggested changes
Oct 16, 2023
There was a problem hiding this comment.
tested 598daea
now discrete mode hover works.
But when hovering over the discrete mode eye ball in the tx history data grid, the icon disappears and comes back, but it does not reveal the actual non-discrete-mode icon.
For some unknow yet reason same logic does not work for this two columns (indicators and labels). This is probably TDG invalidation issues and for custom cells we have for other columns it works. I did try rewrite invalidation using common styled properties instead observable but did not help. One solution is to migrate to custom cells but those columns are complex. Will try to do some custom invalidation and see if it helps. |
|
We discussed this PR and decided to merge. It still has some minor issues which will be fixed in the following PR, but apart from those it is fine to get in. So we can start the work on those items as well that were waiting for V11. Tomorrow I will do a final testing and hit the merge button. |
soosr
approved these changes
Oct 18, 2023
This was referenced Oct 18, 2023
|
Woop woop, congrats! 🎉🚀 |
This was referenced Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debug tools
Reviews
Avalonia Issues
TODO
DONE
<SolidColorBrush x:Key="TreeDataGridGridLinesBrush" Color="{StaticResource SystemListLowColor}" />and we override theSystemListLowColor.Docs: