Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trivial][VDG] Rename Incoming and Outgoing columns to Received and Sent amounts #11189

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

yahiheb
Copy link
Collaborator

@yahiheb yahiheb commented Aug 2, 2023

This PR renames the Incoming/Outgoing columns in the transaction history and the Incoming and Outgoing sections in the transaction details to Received and Sent amounts.

Reasons why this makes sense:

Properties like IncomingAmount, OutgoingAmount could be renamed in this PR or in a follow up one.

@yahiheb yahiheb requested a review from soosr October 7, 2023 22:04
Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the transaction icon tooltips too

@yahiheb
Copy link
Collaborator Author

yahiheb commented Oct 9, 2023

Please update the transaction icon tooltips too

As I stated in the PR description The terms incoming and outgoing are more used for payments or transactions not for amounts so I think the transaction tooltips are fine IMO.

@soosr soosr merged commit 35bdb33 into WalletWasabi:master Oct 9, 2023
7 checks passed
@yahiheb yahiheb deleted the columns-sent-received branch October 9, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants