[VDG] Fix WalletModel multiple instances #11302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichthus1604
changed the title
|
Tested, it fixes #10944 |
soosr
previously approved these changes
Aug 17, 2023
|
@ichthus1604 UI decoupling 35 caused conflict here, could you fix it? |
|
@soosr done |
soosr
requested changes
Aug 22, 2023
soosr
previously approved these changes
Aug 23, 2023
soosr
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TransformWithInlineUpdate()actually retain previous instances instead of creating new ones.This requires thorough testing. I have made basic tests (send/receive/new wallet) but since this is a deep change it might have unexpected consequences