-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add words to exclusion.dic #11329
Add words to exclusion.dic #11329
Conversation
Ready to review? |
Yes. There are still more words to be added but I will do that in a follow up PR. |
So isn't it a good idea to sort the entries now? |
We can do it in another PR, but notice that there are two groups of words and whenever editing this file one has to be careful to sort those groups separately. |
adfacaab | ||
edcaeba | ||
afca |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not too sure about these. Imho it might be good to add it to a special group as well because these are clearly not words.
no, it is OK. |
The point of this is to help coders point out spelling errors - those can be extremely annoying in the case of a method name or property, even more, so if fixing would make a breaking change. The secondary goal is to have fewer typos in the code, reducing the number of reviews on the PR. |
These goals are satisfied with the current solution - I will merge this. |
This PR adds some words to exclusion.dic to be excluded from Spell Checker.