Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add words to exclusion.dic #11329

Merged
merged 6 commits into from
Sep 22, 2023
Merged

Conversation

yahiheb
Copy link
Collaborator

@yahiheb yahiheb commented Aug 20, 2023

This PR adds some words to exclusion.dic to be excluded from Spell Checker.

@molnard
Copy link
Collaborator

molnard commented Sep 22, 2023

Ready to review?

@pull-request-size pull-request-size bot added size/M and removed size/S labels Sep 22, 2023
@yahiheb yahiheb marked this pull request as ready for review September 22, 2023 10:47
@yahiheb
Copy link
Collaborator Author

yahiheb commented Sep 22, 2023

Ready to review?

Yes.

There are still more words to be added but I will do that in a follow up PR.

@kiminuo
Copy link
Collaborator

kiminuo commented Sep 22, 2023

So isn't it a good idea to sort the entries now?

@yahiheb
Copy link
Collaborator Author

yahiheb commented Sep 22, 2023

So isn't it a good idea to sort the entries now?

We can do it in another PR, but notice that there are two groups of words and whenever editing this file one has to be careful to sort those groups separately.

Comment on lines +277 to +279
adfacaab
edcaeba
afca
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not too sure about these. Imho it might be good to add it to a special group as well because these are clearly not words.

@molnard
Copy link
Collaborator

molnard commented Sep 22, 2023

sort the entries now

no, it is OK.

@molnard
Copy link
Collaborator

molnard commented Sep 22, 2023

The point of this is to help coders point out spelling errors - those can be extremely annoying in the case of a method name or property, even more, so if fixing would make a breaking change. The secondary goal is to have fewer typos in the code, reducing the number of reviews on the PR.

@molnard
Copy link
Collaborator

molnard commented Sep 22, 2023

These goals are satisfied with the current solution - I will merge this.

@molnard molnard merged commit cea4512 into WalletWasabi:master Sep 22, 2023
6 of 7 checks passed
@yahiheb yahiheb deleted the typos-spell-checker branch September 22, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants