-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Wasabi crash if exception happens after PreviewTx screen #11338
Conversation
I think it was not accepted before because this approach is just hides the problem and wraps it inside a try-catch block. I think showing an error dialog is a tiny bit better than crashing the software, but still the issue is there just as before, and we don't present a solution to the user how to overcome the issue. |
I absolutely agree with this, the main problem should be found & fixed at the deeper level. |
WalletWasabi.Fluent/ViewModels/Wallets/Send/TransactionPreviewViewModel.cs
Outdated
Show resolved
Hide resolved
To noteThis PR doesn't fix the main, deep problem of #11191 and #10171, this just fixes the wallet crashing because of these kind of errors. var transaction = await Task.Run(() => TransactionHelpers.BuildTransaction(_wallet, _info));
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
Addresses #11191
Addresses #10171
and probably more in the future.
Already suggested this fix in the past for different problems, not sure why it was not accepted.
At this point, if an exception does occur somehow even before trying to finalize and send, just when we build the tx, we should raise the exception and throw out a message because something is deffinetly not ok, and we can prevent the wallet crash as well.
This PR just widens the try/catch.