-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WasabiSynchronizer
: Add InitialRequestTcs
#11343
WasabiSynchronizer
: Add InitialRequestTcs
#11343
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK on TestNet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK.
I'm interested in removing this: https://github.com/kiminuo/WalletWasabi/blob/925ca7c3283a90137b785ec83e7140bc3731ead3/WalletWasabi.Fluent/Models/Wallets/WalletLoadWorkflow.cs#L106-L109 Is there a way to guarantee that |
…allet # Conflicts: # WalletWasabi.Fluent/Models/Wallets/WalletLoadWorkflow.cs
Unfortunately, there was conflict with #11246. Resolved.
I would like to fix it in a next step. |
var processedCount = GetCurrentProcessedCount(); | ||
UpdateProgress(processedCount); | ||
}) | ||
.Subscribe( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just fix whitespace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK.
Follow-up to #11303
Tries to simplify the wallet loading a bit as explained in #11303 (comment)
Thinking about it, I don't think we need https://github.com/kiminuo/WalletWasabi/blob/925ca7c3283a90137b785ec83e7140bc3731ead3/WalletWasabi.Fluent/Models/Wallets/WalletLoadWorkflow.cs#L76-L81 now.
Review with whitespace off.