Bump required .NET SDK version to 7.0.304 #11367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbolay
approved these changes
Aug 23, 2023
yahiheb
approved these changes
Aug 24, 2023
wieslawsoltes
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #11357
Lucas mentioned that
7.0.304is actually required to build the project on Linux (see). I don't want to overdo the bumps. However, given that we know that build breaks on lower SDKs for a supported platform, and also it fails in a specific way that it looks like the source code is broken. I guess it's better to bump it.Note that this bumping should not be necessary in the future (馃) because what we deal with here is that .NET compiler incorrectly runs source analyzers and build fails then.