Ban doublespenders #11372
Merged
Ban doublespenders #11372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lontivero
force-pushed
the
ban-doublespending
branch
from
a59da80
to
beff176
Compare
Merged
adamPetho
approved these changes
Aug 25, 2023
lontivero
force-pushed
the
ban-doublespending
branch
from
b189c3a
to
22e7f11
Compare
molnard
reviewed
Sep 6, 2023
| public void BanDoubleSpenders(object? sender, Transaction tx) | ||
| { | ||
| // Detect and punish double spending coins | ||
| var disrupters = Arena.Rounds |
There was a problem hiding this comment.
@lontivero
This is dangerous. Arena and rounds are not designed to be touched from outside asynchronously. There is a read operation here and later you also close the round.
The only place where we are touching rounds is Arena.ActionAsync and locking AsyncLock.
You need to find a solution how to integrate this into Arena.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for banning coins that were spent after being registered for participation in a coinjoin.