IndexStore: Make SmartHeaderChain property private
#11378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiminuo
commented
Aug 25, 2023
| @@ -251,7 +251,7 @@ public async Task AddNewFiltersAsync(IEnumerable<FilterModel> filters) | |||
| { | |||
| using (await IndexLock.LockAsync(CancellationToken.None).ConfigureAwait(false)) | |||
| { | |||
| await using SqliteTransaction sqliteTransaction = IndexStorage.BeginTransaction(); | |||
| using SqliteTransaction sqliteTransaction = IndexStorage.BeginTransaction(); | |||
There was a problem hiding this comment.
await is not necessary here (it emits a warning) because async is not supported by sqlite (https://learn.microsoft.com/en-gb/dotnet/standard/data/sqlite/async)
kiminuo
commented
Aug 25, 2023
| @@ -70,7 +70,7 @@ public IndexStore(string workFolderPath, Network network, SmartHeaderChain smart | |||
| /// <summary>Run migration if SQLite file does not exist.</summary> | |||
| private bool RunMigration { get; } | |||
|
|
|||
| public SmartHeaderChain SmartHeaderChain { get; } | |||
| private SmartHeaderChain SmartHeaderChain { get; } | |||
adamPetho
approved these changes
Aug 25, 2023
lontivero
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more correct way to pass dependencies.