TX History Refinement fix: Icon + Tooltip of normal transactions #11382

TChukwuleta · 2023-08-27T19:39:13Z

Changed the Tool tip to cater to individual transactions (incoming, outgoing, self-transfer).
Changed the icon for incoming and outgoing transactions.

Left the default icon to cater for self-transfer. From my UX point, it seemed to speak to that regard.

Open to review. Thanks

WalletWasabi/Blockchain/Transactions/SmartTransaction.cs

WalletWasabi.Fluent/ViewModels/Wallets/Home/History/HistoryItems/HistoryItemViewModelBase.cs

yahiheb · 2023-08-27T23:06:06Z

I tested this a bit, LGTM

WalletWasabi/Blockchain/TransactionProcessing/TransactionProcessor.cs

WalletWasabi.Fluent/ViewModels/Wallets/Home/History/HistoryItems/HistoryItemViewModelBase.cs

WalletWasabi.Fluent/Icons/Icons.axaml

…into WalletWasabi#11172

yahiheb

CI is failing because you have accidently removed some bitcoind binaries.

TChukwuleta · 2023-09-01T06:30:48Z

CI is failing because you have accidently removed some bitcoind binaries.

Yea.. Thank you.

Added it back

WalletWasabi.Fluent/ViewModels/Wallets/Home/History/HistoryItems/HistoryItemViewModelBase.cs

WalletWasabi/Blockchain/Transactions/SmartTransaction.cs

yahiheb

Now that there are different icons should the method TransactionsSearchSource.GetIcon be updated?

WalletWasabi.Fluent/Views/Wallets/Home/History/Columns/IndicatorsColumnView.axaml

…alletWasabi into WalletWasabi#11172

WalletWasabi.Fluent/ViewModels/Wallets/Home/History/HistoryItems/HistoryItemViewModelBase.cs

WalletWasabi.Fluent/Views/Wallets/Home/History/Columns/IndicatorsColumnView.axaml

WalletWasabi/Blockchain/Transactions/SmartTransaction.cs

soosr · 2023-09-05T08:10:05Z

WalletWasabi.Fluent/Icons/Icons.axaml

+      <StreamGeometry x:Key="outgoing_arrow">M54.9667 51.3071C54.8519 51.3052 54.7384 51.2806 54.6329 51.2347C54.5275 51.1889 54.432 51.1227 54.3522 51.04C54.2723 50.9572 54.2096 50.8595 54.1676 50.7525C54.1254 50.6455 54.1049 50.5312 54.107 50.4163L54.4649 30.2585L28.2828 55.5271C28.1158 55.6883 27.8916 55.7765 27.6596 55.7724C27.4276 55.7683 27.2067 55.6721 27.0455 55.5052C26.8844 55.3382 26.7961 55.1141 26.8002 54.882C26.8044 54.6499 26.9005 54.4291 27.0675 54.2679L53.2495 28.9993L33.0918 28.6414C32.9768 28.6394 32.8635 28.6147 32.758 28.5688C32.6526 28.5229 32.5572 28.4568 32.4774 28.3741C32.3975 28.2914 32.3348 28.1936 32.2926 28.0867C32.2505 27.9797 32.23 27.8655 32.232 27.7505C32.234 27.6356 32.2587 27.5222 32.3045 27.4168C32.3504 27.3113 32.4166 27.2159 32.4993 27.1361C32.5821 27.0562 32.6797 26.9935 32.7867 26.9514C32.8937 26.9093 33.0079 26.8887 33.1229 26.8907L55.3932 27.2861C55.5082 27.288 55.6217 27.3127 55.7272 27.3585C55.8326 27.4044 55.9279 27.4706 56.0077 27.5534C56.0877 27.6361 56.1504 27.7337 56.1925 27.8408C56.2346 27.9477 56.2552 28.062 56.253 28.177L55.8576 50.4474C55.8557 50.5623 55.8311 50.6758 55.7852 50.7813C55.7393 50.8867 55.6732 50.982 55.5904 51.062C55.5077 51.1418 55.41 51.2046 55.3031 51.2466C55.196 51.2887 55.0817 51.3093 54.9667 51.3071Z</StreamGeometry>
+      <StreamGeometry x:Key="incoming_arrow">M26.8613 30.9335C26.9762 30.9334 27.0901 30.956 27.1964 31C27.3026 31.0439 27.3992 31.1084 27.4805 31.1897C27.5618 31.271 27.6263 31.3676 27.6702 31.4738C27.7142 31.5801 27.7368 31.694 27.7367 31.8089L27.7367 51.9699L53.4661 26.2405C53.6302 26.0764 53.8528 25.9842 54.0849 25.9842C54.3169 25.9842 54.5395 26.0764 54.7036 26.2405C54.8677 26.4046 54.9599 26.6271 54.9599 26.8592C54.9599 27.0913 54.8677 27.3138 54.7036 27.4779L28.9742 53.2073L49.1351 53.2073C49.2501 53.2073 49.3639 53.23 49.4702 53.274C49.5764 53.318 49.6729 53.3824 49.7542 53.4637C49.8355 53.545 49.9 53.6416 49.944 53.7478C49.988 53.854 50.0106 53.9678 50.0106 54.0828C50.0106 54.1978 49.988 54.3116 49.944 54.4178C49.9 54.5241 49.8355 54.6206 49.7542 54.7019C49.6729 54.7832 49.5764 54.8477 49.4702 54.8917C49.3639 54.9357 49.2501 54.9583 49.1351 54.9583L26.8613 54.9583C26.7463 54.9584 26.6324 54.9358 26.5261 54.8918C26.4199 54.8478 26.3234 54.7833 26.2421 54.702C26.1607 54.6207 26.0963 54.5242 26.0523 54.4179C26.0083 54.3117 25.9857 54.1978 25.9858 54.0828L25.9858 31.8089C25.9857 31.694 26.0083 31.5801 26.0523 31.4738C26.0963 31.3676 26.1607 31.2711 26.2421 31.1897C26.3234 31.1084 26.4199 31.0439 26.5261 31C26.6324 30.956 26.7463 30.9334 26.8613 30.9335Z</StreamGeometry>


These icons don't fit the fluent style. In general, we use icons from the fluent icon pack:

https://github.com/microsoft/fluentui-system-icons/blob/master/icons_regular.md

https://github.com/microsoft/fluentui-system-icons/blob/master/icons_filled.md

In the future try to only use icons from those. If we don't find a good icon, then we usually create one based on the fluent icon design rules.

I picked icons from the pack mentioned above, so they are like this now:

Oh.. Noted.

Thank you

soosr

tACK

MarnixCroes · 2023-09-05T08:36:45Z

Would be good to squash commits.

yahiheb

tACK

TX History Refinement fix: Icon + Tooltip of normal transactions

0b7bc79

pull-request-size bot added the size/M label Aug 27, 2023

.

7305c29

yahiheb requested changes Aug 27, 2023

View reviewed changes

TChukwuleta added 2 commits August 29, 2023 07:39

rename object property

d2c85fc

Remove multiple blank line

f7bf8ac

soosr reviewed Aug 29, 2023

View reviewed changes

TChukwuleta added 2 commits August 29, 2023 21:18

Merge branch 'master' of https://github.com/TChukwuleta/WalletWasabi …

da86ee4

…into WalletWasabi#11172

Refactor

23e7903

pull-request-size bot added size/S and removed size/M labels Aug 30, 2023

yahiheb requested changes Aug 31, 2023

View reviewed changes

Recovered bitcoind binaries

995a327

yahiheb requested changes Sep 1, 2023

View reviewed changes

WalletWasabi.Fluent/ViewModels/Wallets/Home/History/HistoryItems/HistoryItemViewModelBase.cs Outdated Show resolved Hide resolved

WalletWasabi/Blockchain/Transactions/SmartTransaction.cs Outdated Show resolved Hide resolved

yahiheb requested changes Sep 1, 2023

View reviewed changes

WalletWasabi/Blockchain/Transactions/SmartTransaction.cs Outdated Show resolved Hide resolved

TChukwuleta and others added 7 commits September 1, 2023 15:06

TX History Refinement fix: Icon + Tooltip of normal transactions

821a927

.

a6d6d17

rename object property

c5abb6a

Remove multiple blank line

5d71535

Refactor

5af4479

Recovered bitcoind binaries

e976d17

Format

21efa3f

yahiheb force-pushed the #11172 branch from ed25187 to 21efa3f Compare September 1, 2023 14:08

yahiheb requested changes Sep 1, 2023

View reviewed changes

TChukwuleta added 2 commits September 2, 2023 03:14

Merge branch 'WalletWasabi#11172' of https://github.com/TChukwuleta/W…

106dfb2

…alletWasabi into WalletWasabi#11172

Refactor/update based on change requested

76703ae

pull-request-size bot added size/M and removed size/S labels Sep 2, 2023

yahiheb requested changes Sep 2, 2023

View reviewed changes

Update SmartTransaction.cs

af35ce7

pull-request-size bot added size/S and removed size/M labels Sep 3, 2023

TChukwuleta and others added 3 commits September 3, 2023 03:32

revert smarttransaction file changes. Removal of paranthesis

325f31e

undo changes in SmartTransaction class

dcda642

Merge branch 'master' into WalletWasabi#11172

40d96be

soosr reviewed Sep 5, 2023

View reviewed changes

final touches

e982a40

pull-request-size bot added size/M and removed size/S labels Sep 5, 2023

soosr added 2 commits September 5, 2023 10:15

final final touches

a525f7c

Fix icon for pending transactions

a2e1322

soosr approved these changes Sep 5, 2023

View reviewed changes

soosr requested a review from yahiheb September 5, 2023 08:28

yahiheb approved these changes Sep 5, 2023

View reviewed changes

soosr merged commit c6748d1 into WalletWasabi:master Sep 5, 2023
6 of 7 checks passed

MarnixCroes mentioned this pull request Sep 9, 2023

update history images WalletWasabi/WasabiDoc#1589

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TX History Refinement fix: Icon + Tooltip of normal transactions #11382

TX History Refinement fix: Icon + Tooltip of normal transactions #11382

TChukwuleta commented Aug 27, 2023 •

edited by soosr

yahiheb commented Aug 27, 2023

yahiheb left a comment

TChukwuleta commented Sep 1, 2023

yahiheb left a comment

soosr Sep 5, 2023

TChukwuleta Sep 5, 2023

soosr left a comment

MarnixCroes commented Sep 5, 2023

yahiheb left a comment

		<StreamGeometry x:Key="outgoing_arrow">M54.9667 51.3071C54.8519 51.3052 54.7384 51.2806 54.6329 51.2347C54.5275 51.1889 54.432 51.1227 54.3522 51.04C54.2723 50.9572 54.2096 50.8595 54.1676 50.7525C54.1254 50.6455 54.1049 50.5312 54.107 50.4163L54.4649 30.2585L28.2828 55.5271C28.1158 55.6883 27.8916 55.7765 27.6596 55.7724C27.4276 55.7683 27.2067 55.6721 27.0455 55.5052C26.8844 55.3382 26.7961 55.1141 26.8002 54.882C26.8044 54.6499 26.9005 54.4291 27.0675 54.2679L53.2495 28.9993L33.0918 28.6414C32.9768 28.6394 32.8635 28.6147 32.758 28.5688C32.6526 28.5229 32.5572 28.4568 32.4774 28.3741C32.3975 28.2914 32.3348 28.1936 32.2926 28.0867C32.2505 27.9797 32.23 27.8655 32.232 27.7505C32.234 27.6356 32.2587 27.5222 32.3045 27.4168C32.3504 27.3113 32.4166 27.2159 32.4993 27.1361C32.5821 27.0562 32.6797 26.9935 32.7867 26.9514C32.8937 26.9093 33.0079 26.8887 33.1229 26.8907L55.3932 27.2861C55.5082 27.288 55.6217 27.3127 55.7272 27.3585C55.8326 27.4044 55.9279 27.4706 56.0077 27.5534C56.0877 27.6361 56.1504 27.7337 56.1925 27.8408C56.2346 27.9477 56.2552 28.062 56.253 28.177L55.8576 50.4474C55.8557 50.5623 55.8311 50.6758 55.7852 50.7813C55.7393 50.8867 55.6732 50.982 55.5904 51.062C55.5077 51.1418 55.41 51.2046 55.3031 51.2466C55.196 51.2887 55.0817 51.3093 54.9667 51.3071Z</StreamGeometry>
		<StreamGeometry x:Key="incoming_arrow">M26.8613 30.9335C26.9762 30.9334 27.0901 30.956 27.1964 31C27.3026 31.0439 27.3992 31.1084 27.4805 31.1897C27.5618 31.271 27.6263 31.3676 27.6702 31.4738C27.7142 31.5801 27.7368 31.694 27.7367 31.8089L27.7367 51.9699L53.4661 26.2405C53.6302 26.0764 53.8528 25.9842 54.0849 25.9842C54.3169 25.9842 54.5395 26.0764 54.7036 26.2405C54.8677 26.4046 54.9599 26.6271 54.9599 26.8592C54.9599 27.0913 54.8677 27.3138 54.7036 27.4779L28.9742 53.2073L49.1351 53.2073C49.2501 53.2073 49.3639 53.23 49.4702 53.274C49.5764 53.318 49.6729 53.3824 49.7542 53.4637C49.8355 53.545 49.9 53.6416 49.944 53.7478C49.988 53.854 50.0106 53.9678 50.0106 54.0828C50.0106 54.1978 49.988 54.3116 49.944 54.4178C49.9 54.5241 49.8355 54.6206 49.7542 54.7019C49.6729 54.7832 49.5764 54.8477 49.4702 54.8917C49.3639 54.9357 49.2501 54.9583 49.1351 54.9583L26.8613 54.9583C26.7463 54.9584 26.6324 54.9358 26.5261 54.8918C26.4199 54.8478 26.3234 54.7833 26.2421 54.702C26.1607 54.6207 26.0963 54.5242 26.0523 54.4179C26.0083 54.3117 25.9857 54.1978 25.9858 54.0828L25.9858 31.8089C25.9857 31.694 26.0083 31.5801 26.0523 31.4738C26.0963 31.3676 26.1607 31.2711 26.2421 31.1897C26.3234 31.1084 26.4199 31.0439 26.5261 31C26.6324 30.956 26.7463 30.9334 26.8613 30.9335Z</StreamGeometry>

TX History Refinement fix: Icon + Tooltip of normal transactions #11382

TX History Refinement fix: Icon + Tooltip of normal transactions #11382

Conversation

TChukwuleta commented Aug 27, 2023 • edited by soosr

yahiheb commented Aug 27, 2023

yahiheb left a comment

Choose a reason for hiding this comment

TChukwuleta commented Sep 1, 2023

yahiheb left a comment

Choose a reason for hiding this comment

soosr Sep 5, 2023

Choose a reason for hiding this comment

TChukwuleta Sep 5, 2023

Choose a reason for hiding this comment

soosr left a comment

Choose a reason for hiding this comment

MarnixCroes commented Sep 5, 2023

yahiheb left a comment

Choose a reason for hiding this comment

TChukwuleta commented Aug 27, 2023 •

edited by soosr