Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create ReleaseNotesTemplate.md #11387

Merged
merged 11 commits into from
Aug 29, 2023
Merged

Create ReleaseNotesTemplate.md #11387

merged 11 commits into from
Aug 29, 2023

Conversation

MarnixCroes
Copy link
Collaborator

closes #11294

Create a new directory ClientRelease and create the file ReleaseNotesTemplate.md, as requested #11294 (comment)

Should the file ClientDeployment.md moved to the ClientRelease directory as well?

@MarnixCroes
Copy link
Collaborator Author

MarnixCroes commented Aug 28, 2023 •
edited

@MaxHillebrand @molnard @adamPetho please check if it works for you (in combination with some of the auto generated parts)

MaxHillebrand
MaxHillebrand previously approved these changes Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@MaxHillebrand MaxHillebrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Should the file ClientDeployment.md moved to the ClientRelease directory as well?

Yes

MaxHillebrand
MaxHillebrand reviewed Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@MaxHillebrand MaxHillebrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit is to remove 2.0.4 related content.

WalletWasabi.Documentation/ClientRelease/ReleaseNotesTemplate.md Outdated Show resolved Hide resolved
WalletWasabi.Documentation/ClientRelease/ReleaseNotesTemplate.md Outdated Show resolved Hide resolved
MaxHillebrand
MaxHillebrand suggested changes Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@MaxHillebrand MaxHillebrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move documentation above the advanced guide.

@MarnixCroes
Copy link
Collaborator Author

MarnixCroes commented Aug 28, 2023 •
edited

Move documentation above the advanced guide.

done
edit: the commit contained some weird avalonia file bug, pushed a fix

MaxHillebrand
MaxHillebrand previously approved these changes Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@MaxHillebrand MaxHillebrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MaxHillebrand and others added 2 commits August 29, 2023 09:23
@MaxHillebrand @yahiheb
Update WalletWasabi.Documentation/ClientRelease/ReleaseNotesTemplate.md
19f08ec 
Co-authored-by: yahiheb <52379387+yahiheb@users.noreply.github.com>
@MaxHillebrand @yahiheb
Update WalletWasabi.Documentation/ClientRelease/ReleaseNotesTemplate.md
97737dd 
Co-authored-by: yahiheb <52379387+yahiheb@users.noreply.github.com>
yahiheb
yahiheb approved these changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

molnard
molnard requested changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@molnard molnard left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it does look different.

image

Latest release

image

@MarnixCroes
Copy link
Collaborator Author

@molnard I'm not sure what happens there. I cannot repro, for me it looks fine if I preview it

molnard
molnard approved these changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@molnard molnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

https://github.com/molnard/WalletWasabi/releases/tag/test2

@molnard molnard merged commit f844a69 into WalletWasabi:master Aug 29, 2023
7 checks passed
@MarnixCroes MarnixCroes deleted the ReleaseNotesTemplate branch August 29, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxHillebrand MaxHillebrand MaxHillebrand left review comments

@molnard molnard molnard approved these changes

@yahiheb yahiheb yahiheb approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add empty Release Notes template to repository
4 participants
@MarnixCroes @molnard @MaxHillebrand @yahiheb