[VDG] Auto login after Create New Wallet / Recover Wallet

[ichthus1604]

• Logs the wallet in automatically after Create New Wallet and Recover Wallet workflows.
• Properly deals with Terms and Conditions, presenting the acceptance dialog if needed.
• Fixes [VDG] password input three times at wallet generation  #10367
• Closes [VDG] Try to login into wallet after creation #11337

[MarnixCroes]

This concept requires the user to really understand the password, and could lead to (more) loss of funds:
Use creates a wallet -> gets logged in and receives bitcoin.
Then some time later launches Wasabi again and doesn't know the password.

Requiring the user to enter the password before login is somewhat of a feature imo, to double check knowledge of the password.

I'm not here to nack to, but I'm not sure if the "gain" is bigger than the potential loss.

[Szpoti]

I'm not here to nack to, but I'm not sure if the "gain" is bigger than the potential loss.

Not sure how much better this option would be, IDK how many users actually use a password, but maybe we can auto-login on wallets which doesn't have a password?

[soosr]

Currently, we are asking for the password 3 times within 15 seconds. I am doubting that the 3rd one makes the user remember it.
Moreover, most people have a usual password, and not like they use a totally different one each time they register somewhere.
They won't forget it.

[yahiheb]

Maybe this is not related to this PR but I experienced the following while testing this.

• Started with a fresh Wasabi data folder
• Recovered a wallet (empty)
• Waited for the filters to finish downloading (which took ~1h and 40min)
• Now the wallet is stuck for over 30 minutes

Note that I still didn't get to see the Terms and Conditions dialog.

2023-08-31 11:00:08.448 [50] INFO       FilterProcessor.ProcessAsync (54)       Downloaded filters for blocks from 803825 to 804824.
2023-08-31 11:00:54.290 [31] INFO       FilterProcessor.ProcessAsync (54)       Downloaded filters for blocks from 804825 to 805568.
2023-08-31 11:02:29.118 [51] INFO       HybridFeeProvider.OnAllFeeEstimateArrived (132) Accurate fee rates are acquired from WasabiSynchronizer ranging from target 2 blocks at 17 sat/vByte to target 72 blocks at 7 sat/vByte.
2023-08-31 11:07:44.818 [49] INFO       HybridFeeProvider.OnAllFeeEstimateArrived (132) Accurate fee rates are acquired from WasabiSynchronizer ranging from target 2 blocks at 17 sat/vByte to target 72 blocks at 7 sat/vByte.
2023-08-31 11:11:57.205 [30] INFO       HybridFeeProvider.OnAllFeeEstimateArrived (132) Accurate fee rates are acquired from WasabiSynchronizer ranging from target 2 blocks at 20 sat/vByte to target 72 blocks at 7 sat/vByte.
2023-08-31 11:19:51.998 [50] INFO       HybridFeeProvider.OnAllFeeEstimateArrived (132) Accurate fee rates are acquired from WasabiSynchronizer ranging from target 2 blocks at 20 sat/vByte to target 72 blocks at 7 sat/vByte.

[soosr]

Maybe this is not related to this PR but I experienced the following while testing this.

• Started with a fresh Wasabi data folder
• Recovered a wallet (empty)
• Waited for the filters to finish downloading (which took ~1h and 40min)
• Now the wallet is stuck for over 30 minutes

Not related.

Note that I still didn't get to see the Terms and Conditions dialog.

If it is not downloaded when the wallet is being logged in, it won't show up.
On the second login, it will.

[yahiheb]

tACK

[yahiheb]

One thing that would improve the wallet creation/recovery workflow further is to remove this dialog.
It doesn't add any real value and just adds an extra step, the user would know that their wallet was added once it is automatically logged in.
This can be done in a follow up PR if it is complex.

[soosr]

tACK

[yahiheb]

tACK