Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert RoundParameter that made clients to trust #11395

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Revert RoundParameter that made clients to trust #11395

merged 2 commits into from
Aug 29, 2023

Conversation

lontivero
Copy link
Collaborator

@lontivero lontivero commented Aug 29, 2023 •
edited

This reverts commit 197ecce. And only take the suggestion to have DelayTransactionSigning to false by default.

image

@lontivero lontivero requested a review from kiminuo August 29, 2023 16:46
kiminuo
kiminuo approved these changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@kiminuo kiminuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK1

Footnotes

  1. I still think we are a bunch of people who can read a PR diff even if it introduces a new constant. ↩

@lontivero lontivero merged commit f365697 into WalletWasabi:master Aug 29, 2023
6 of 7 checks passed
@onvej-sl onvej-sl mentioned this pull request Sep 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiminuo kiminuo kiminuo approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lontivero @kiminuo