[VDG] Combined AutoNotify Source Generator #11403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soosr
approved these changes
Sep 4, 2023
|
This PR was merged without any changes? or was there an error? |
|
It was a PR chain where the topmost got merged so every PR below should have gotten merged as well. For some reason it didn't happen in this PR so I merged it manually for the sake of correctness. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Turns out the
AutoNotifyis also required in the combined source generator pipeline forAutoInterface, because otherwise the properties generated by the former aren't recognized by the latter, therefore those properties are not added to the generated interfaces.This PR adds the
AutoNotifyGeneratorinto the Combined Source Generator API.