Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global: Fix warning #11420

Merged

Conversation

kiminuo
Copy link
Collaborator

@kiminuo kiminuo commented Sep 4, 2023

No description provided.

@@ -247,10 +247,10 @@ protected virtual void Dispose(bool disposing)
{
var blockNotifier = HostedServices.Get<BlockNotifier>();
blockNotifier.OnBlock -= wabiSabiCoordinator.BanDescendant;
P2pNode.OnTransactionArrived -= wabiSabiCoordinator.BanDoubleSpenders;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved here because this block is checked with if (WabiSabiCoordinator is { } wabiSabiCoordinator)

Copy link
Collaborator

@adamPetho adamPetho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

@kiminuo kiminuo merged commit 4c93173 into WalletWasabi:master Sep 4, 2023
7 checks passed
@kiminuo kiminuo deleted the feature/2023-09-04-fix-warning branch September 4, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants