-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Failed to signal ready to sign" - Prison extension #11422
"Failed to signal ready to sign" - Prison extension #11422
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK.
Code LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing parts:
- You have to serialize and deserialize the new type of disruption; otherwise they will not be persisted.
- Update unit tests for this new type of disruption.
WalletWasabi/WabiSabi/Backend/DoSPrevention/DoSConfiguration.cs
Outdated
Show resolved
Hide resolved
@lontivero There is a bit more complex unit test called |
I think it is just a bit less than FailedToSign because it wastes less time from everybody else but don't worry about that, you can make it the same as FailedToSing for the test because in the end these factors have to be tweaked in production. |
This PR is made to address this https://github.com/zkSNACKs/WalletWasabi/pull/11115/files#r1294451295
and to push forward #11115 PR.
This PR adds a new method to Prison called
FailedToSignalReadyToSign
.On master this method is not yet used. It will be used in #11115 AFAIK.
FailedToSignalReadyToSign
has the same penalty factor values asFailedToSign
. Please let me know if this should be different.