Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VDG] Privacy Warning: Transaction Known as yours by #11432

Merged
merged 6 commits into from
Sep 12, 2023

Conversation

ichthus1604
Copy link
Collaborator

We can detect if the transaction spends from more than one pocket

  • if YES: Transaction interlinks labels will be displayed
    • (Still not true in every scenario, but ok to show this)
  • if NO: Transaction known as yours by

Those entities know this is your transaction. Coinjoin more or use the label management tool to carefully select who would know that this transaction is yours.

That seems more suitable for the new TransactionKnownAsYoursBy warning, maybe we should modify the former?

Copy link
Collaborator

@MarnixCroes MarnixCroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those entities know this is your transaction. Coinjoin more or use the label management tool to carefully select who would know that this transaction is yours.

That seems more suitable for the new TransactionKnownAsYoursBy warning, maybe we should modify the former?

  • I think it's alright, I would just change it to singular instead of plural. see suggestion

  • Should the TransactionKnownAsYoursBy message also be displayed when sending a coin labeled Alice to recipient label Alice?
    Currently it just says tx is private.

Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@soosr soosr merged commit 0bc7485 into WalletWasabi:master Sep 12, 2023
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Privacy Suggestion: "transaction interlinks labels" when wallet has only 1 non-private coin
3 participants