Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VDG] Use file-scoped namespaces in source generators #11434

Conversation

wieslawsoltes
Copy link
Collaborator

@wieslawsoltes wieslawsoltes commented Sep 6, 2023

  • Updated source generators to use file-scoped namespaces
  • Update generators to use raw string literals for code strings
  • Fixed indentation to use tabs in source generated code

@wieslawsoltes wieslawsoltes marked this pull request as ready for review September 6, 2023 10:44
Copy link
Collaborator

@SuperJMN SuperJMN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yahiheb
yahiheb previously approved these changes Sep 6, 2023
Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@ichthus1604 ichthus1604 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK. Approved with minor changes

@ichthus1604 ichthus1604 merged commit a4f4bc0 into WalletWasabi:master Sep 7, 2023
3 of 6 checks passed
@wieslawsoltes wieslawsoltes deleted the vdg/FileScopedNamespacesGenerator branch September 7, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants