[Trivial] Change namespace to match folder structure #11447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamPetho
reviewed
Sep 8, 2023
| @@ -9,6 +9,7 @@ | |||
| using WalletWasabi.Fluent.ViewModels.Dialogs.Base; | |||
| using WalletWasabi.Fluent.ViewModels.Navigation; | |||
| using WalletWasabi.Fluent.ViewModels.Wallets; | |||
| using WalletWasabi.Tests.UnitTests.ViewModels.UIContext; | |||
There was a problem hiding this comment.
Why? In my IDE this is an unnecessary using.
There was a problem hiding this comment.
I renamed that folder/namespace from UiContext to UIContext because of a conflict with the UiContext class.
On my IDE (VS2022) it is necessary. What IDE do you use?
There was a problem hiding this comment.
I was stupid, nevermind my comments.
| @@ -6,6 +6,7 @@ | |||
| using WalletWasabi.Fluent.ViewModels.Dialogs.Base; | |||
| using WalletWasabi.Fluent.ViewModels.Navigation; | |||
| using WalletWasabi.Tests.UnitTests.ViewModels.TestDoubles; | |||
| using WalletWasabi.Tests.UnitTests.ViewModels.UIContext; | |||
There was a problem hiding this comment.
Same here. In my IDE this is just an unnecessary using
adamPetho
approved these changes
Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.