Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VDG] Coinjoin profiles: Fix wrong item activation area. #11452

Merged
merged 8 commits into from
Sep 14, 2023
Merged

[VDG] Coinjoin profiles: Fix wrong item activation area. #11452

merged 8 commits into from
Sep 14, 2023

Conversation

SuperJMN
Copy link
Collaborator

@SuperJMN SuperJMN commented Sep 8, 2023

Fixes 9599

The coinjoin strategies can be selected by hovering above or under the coinjoin strategy buttons.

The hitbox was wrong.

@SuperJMN SuperJMN self-assigned this Sep 8, 2023
MarnixCroes
MarnixCroes approved these changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@MarnixCroes MarnixCroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 2402444

ichthus1604
ichthus1604 requested changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@ichthus1604 ichthus1604 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buttons dropshadow is cut off:

image

Versus master:

image

yahiheb
yahiheb previously approved these changes Sep 10, 2023
View reviewed changes
Copy link
Collaborator

@yahiheb yahiheb left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

Edit: The PR fixes the issue, but ichthus1604's suggestion should be addressed of course.

soosr
soosr requested changes Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is broken, smallest dialog size (no full screen dialog triggered), it would be nice if we could keep the original behavior. Please take a look

Master:
image

PR:
image

WalletWasabi.Fluent/Views/CoinJoinProfiles/CoinJoinProfilesView.axaml Outdated Show resolved Hide resolved
@SuperJMN SuperJMN requested a review from soosr September 13, 2023 07:55
yahiheb
yahiheb approved these changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@soosr soosr merged commit 3f3a611 into WalletWasabi:master Sep 14, 2023
6 of 7 checks passed
@SuperJMN SuperJMN deleted the fixes/9599-wip-border-activation branch September 14, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soosr soosr soosr approved these changes

@yahiheb yahiheb yahiheb approved these changes

@MarnixCroes MarnixCroes MarnixCroes approved these changes

@ichthus1604 ichthus1604 Awaiting requested review from ichthus1604

Assignees

@SuperJMN SuperJMN

Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Coinjoin Strategy dialog issues
5 participants
@SuperJMN @soosr @yahiheb @MarnixCroes @ichthus1604