[VDG] Privacy warnings Improved UX #11463
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 2 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
Details
🚩 Declining Code Health (highest to lowest):
- Large Method TransactionPreviewViewModel.cs: TransactionPreviewViewModel 🔥
- Complex Conditional PrivacySuggestionsModel.cs: VerifyChangeAsync
✅ Improving Code Health:
- Overall Code Complexity PrivacySuggestionsModel.cs
Annotations
Check notice on line 25 in WalletWasabi.Fluent/Models/Transactions/PrivacySuggestion.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (master)
ℹ Getting worse: Excess Number of Function Arguments
ChangeAvoidanceSuggestion increases from 5 to 6 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
Check notice on line 213 in WalletWasabi.Fluent/Models/Transactions/PrivacySuggestionsModel.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (master)
ℹ Getting worse: Complex Method
VerifyPrivacyLevel increases in cyclomatic complexity from 22 to 23, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 251 in WalletWasabi.Fluent/Models/Transactions/PrivacySuggestionsModel.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (master)
❌ New issue: Complex Conditional
VerifyChangeAsync has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
Check notice on line 1 in WalletWasabi.Fluent/Models/Transactions/PrivacySuggestionsModel.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (master)
✅ Getting better: Overall Code Complexity
The mean cyclomatic complexity decreases from 4.85 to 4.79, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (master)
❌ Getting worse: Large Method
TransactionPreviewViewModel increases from 78 to 81 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.