Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VDG] Re-enable mark as locked #11468

Merged
merged 3 commits into from
Sep 12, 2023

Conversation

SuperJMN
Copy link
Collaborator

@SuperJMN SuperJMN commented Sep 12, 2023

This effectively re-enables address hiding in the GUI.

It was disabled due to this #10177

Fixes #11442

Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI hides the address now, but when I restart the software it appears again... Please take a look, I think we just need to save the KeyManager to disc.

@SuperJMN SuperJMN requested a review from soosr September 12, 2023 09:17
@SuperJMN
Copy link
Collaborator Author

SuperJMN commented Sep 12, 2023

Tested. Changes are persisted now.

BTW good catch @soosr!

Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@soosr soosr merged commit c0ebe77 into WalletWasabi:master Sep 12, 2023
7 checks passed
@SuperJMN SuperJMN deleted the fixes/11442-enable-hide-address branch September 12, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot delete unused address (hide address awaiting for payment)
2 participants