Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VDG] UI Decoupling #36 #11475

Merged
merged 14 commits into from
Sep 19, 2023
Merged

[VDG] UI Decoupling #36 #11475

merged 14 commits into from
Sep 19, 2023

Conversation

ichthus1604
Copy link
Collaborator

  • Decouples CoinSelectorViewModel
  • Introduces IWalletCoinsModel

@ichthus1604 ichthus1604 mentioned this pull request Aug 16, 2023
Open
soosr
soosr requested changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coin Control dialog is missing some of my pockets:
image

It is clear I have private coins and non private ones too:
image

WalletWasabi.Fluent/Models/Wallets/WalletCoinsModel.cs Outdated Show resolved Hide resolved
@soosr soosr mentioned this pull request Sep 14, 2023
Merged
@ichthus1604
Copy link
Collaborator Author

@soosr

Coin Control dialog is missing some of my pockets:

Can you check again with latest commit?

@soosr
Copy link
Collaborator

soosr commented Sep 18, 2023

@soosr

Coin Control dialog is missing some of my pockets:

Can you check again with latest commit?

I only see the non private coins now
image

soosr
soosr approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@soosr soosr merged commit 97d6044 into WalletWasabi:master Sep 19, 2023
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soosr soosr soosr approved these changes

@SuperJMN SuperJMN Awaiting requested review from SuperJMN

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ichthus1604 @soosr @SuperJMN