Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VDG] UI Decoupling #37 #11476

Merged
merged 5 commits into from
Sep 19, 2023
Merged

Conversation

ichthus1604
Copy link
Collaborator

  • Decouples PrivacyBarViewModel

Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can only see the semi private part...
image

Probably related to:#11475 (review)

Code diff compared to 36 looks good:
https://github.com/ichthus1604/WalletWasabi/compare/UI-Decoupling36...ichthus1604:UI-Decoupling37?expand=1

@pull-request-size pull-request-size bot added size/M and removed size/L labels Sep 19, 2023
Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@soosr soosr merged commit 33233a2 into WalletWasabi:master Sep 19, 2023
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants