-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VDG] UI Decoupling #38 #11478
[VDG] UI Decoupling #38 #11478
Conversation
.CombineLatest(_wallet.Privacy.IsWalletPrivate) | ||
.CombineLatest(_wallet.Coins.List.ToCollection()) | ||
.Flatten() | ||
.Throttle(TimeSpan.FromMilliseconds(250)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see without the throttle it fires many many times... but I don't understand why. Can one of you explain? @ichthus1604 @SuperJMN
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also see the tile is changing right after the wallet got logged in, probably caused by the throttle.
Can we avoid it somehow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@soosr the Sample()
in WalletModel.TransactionProcessed
was causing that. I've removed it in the latest commit. I don't think it makes any practical sense to keep it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was added to UiTriggers
here #10245, because the continous triggering caused UI freeze #10244.
If you remove it from WalletModel, it's fine because History still relies on UiTriggers.
Keep this in mind when you reach History with refactoring. #10245 (review)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
Decouples
PrivacyTileControlViewModel