Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VDG] UI Decoupling #38 #11478

Merged
merged 8 commits into from
Sep 22, 2023
Merged

Conversation

ichthus1604
Copy link
Collaborator

Decouples PrivacyTileControlViewModel

@pull-request-size pull-request-size bot added size/M and removed size/L labels Sep 19, 2023
.CombineLatest(_wallet.Privacy.IsWalletPrivate)
.CombineLatest(_wallet.Coins.List.ToCollection())
.Flatten()
.Throttle(TimeSpan.FromMilliseconds(250))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see without the throttle it fires many many times... but I don't understand why. Can one of you explain? @ichthus1604 @SuperJMN

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also see the tile is changing right after the wallet got logged in, probably caused by the throttle.
Can we avoid it somehow?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soosr the Sample() in WalletModel.TransactionProcessed was causing that. I've removed it in the latest commit. I don't think it makes any practical sense to keep it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was added to UiTriggers here #10245, because the continous triggering caused UI freeze #10244.
If you remove it from WalletModel, it's fine because History still relies on UiTriggers.
Keep this in mind when you reach History with refactoring. #10245 (review)

soosr
soosr previously approved these changes Sep 22, 2023
Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@soosr soosr merged commit 1ac98fd into WalletWasabi:master Sep 22, 2023
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants