-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TransactionSummary
: cleanup
#11490
TransactionSummary
: cleanup
#11490
Conversation
using WalletWasabi.Models; | ||
|
||
namespace WalletWasabi.Blockchain.Transactions; | ||
|
||
public class TransactionSummary | ||
{ | ||
public TransactionSummary(SmartTransaction tx, Money amount, IEnumerable<IInput> inputs, IEnumerable<Output> outputs, IEnumerable<BitcoinAddress> destinationAddresses) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shows that inputs
and outputs
are not used at all.
d56efac
to
8ebf282
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Contains all the safe changes from #11458
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
Meant to simplify #11458 to avoid diff changes like:
something.TransactionId
->something.GetHash()