Publish witnesses only after signing phase is completed [issue 11342] #11498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onvej-sl
reviewed
Sep 15, 2023
|
I think this doesn't worth the effort and extra complexity. I think at this point it is perfectly okay to remove the witnesses completely. Clarification: I am not against this PR btw. |
|
Any update? |
|
Hi @lontivero. The pull-request is still in a draft state. Could you please clarify to me - is this solution ok, or do you want to not publish the witnesses at all? |
|
This is okay. However I think it would be simpler and cleaner to simply remove the witnesses completely. |
|
Ok, sorry, I think this could be confusing for you so, let me clarify it once and forever: this approach (PR) is okay. Continue in this way. |
onvej-sl
approved these changes
Oct 4, 2023
|
Ok, this PR is thus ready for review. |
lontivero
requested changes
Oct 5, 2023
WalletWasabi/WabiSabi/Models/MultipartyTransaction/SigningState.cs
Outdated
Show resolved
Hide resolved
WalletWasabi/WabiSabi/Models/MultipartyTransaction/SigningState.cs
Outdated
Show resolved
Hide resolved
WalletWasabi/WabiSabi/Models/MultipartyTransaction/SigningState.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #11342
Fix - Publish witnesses only after signing phase is completed