[tests] Stop Tor on exit #11503
Merged
[tests] Stop Tor on exit #11503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiminuo
force-pushed
the
feature/2023-09-18-tests-stop-tor-on-exit
branch
from
ce37b5d
to
880241a
Compare
adamPetho
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very simple change that makes using Tor tests a bit nicer.
Currently on
master, you start Tor tests and then a Tor process stays alive. That would be OK but then it prevents you from running your Wasabi Wallet because there is an existing instance of Tor but Wasabi Wallet cannot use that Tor instance because in tests and in production Tor is started slightly differently.So this is a trivial way to make it a bit better. Another step would be to start Tor totally separately with different ports and different folders for tests. I can do it in the future.
Converted to draft for now. I'm testing it.