Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VDG] Do not set transaction displayed state if it's coinjoin as it sets two icon styles in indicators column #11508

Conversation

wieslawsoltes
Copy link
Collaborator

No description provided.

@turbolay
Copy link
Collaborator

turbolay commented Sep 18, 2023

Could #9171 have a similar cause? Seems like a really similar issue

@wieslawsoltes
Copy link
Collaborator Author

Could #9171 have a similar cause? Seems like a really similar issue

My fix is for other indicator but I guess there might be similar issue.

Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we get to refactoring the History, we might consider using enums. It's hard to follow what is shown when.

ACK.

@soosr soosr merged commit f1b5671 into WalletWasabi:master Sep 19, 2023
6 of 7 checks passed
@wieslawsoltes wieslawsoltes deleted the vdg/FixHistoryItemDiplayedIconProperties branch October 5, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants