Dispose UI stuff on exit in the most common case #11511

kiminuo · 2023-09-19T07:14:02Z

See #10844 (comment) for the related discussion.

The goal of the PR is to dispose UI stuff every time, that is:

When user terminates WW with X button.
When CTRL+C is pressed (very early, after application is fully loaded, in the meanwhile)
(Scenarios like restarting one's machine are notoriously hard to test.)

WalletWasabi.Fluent.Desktop/Program.cs

soosr

tACK

Co-authored-by: yahiheb <52379387+yahiheb@users.noreply.github.com>

WalletWasabi.Fluent.Desktop/Program.cs

…ove-dispose

WIP

7b2244f

pull-request-size bot added the size/S label Sep 19, 2023

kiminuo mentioned this pull request Sep 19, 2023

UI & graceful shutdown support #10844

Closed

yahiheb reviewed Sep 19, 2023

View reviewed changes

WalletWasabi.Fluent.Desktop/Program.cs Outdated Show resolved Hide resolved

soosr previously approved these changes Sep 20, 2023

View reviewed changes

kiminuo marked this pull request as ready for review September 20, 2023 08:04

Update WalletWasabi.Fluent.Desktop/Program.cs

4c0a4a4

Co-authored-by: yahiheb <52379387+yahiheb@users.noreply.github.com>

kiminuo dismissed soosr’s stale review via 4c0a4a4 September 20, 2023 08:05

kiminuo requested a review from wieslawsoltes September 20, 2023 08:15

wieslawsoltes reviewed Sep 20, 2023

View reviewed changes

WalletWasabi.Fluent.Desktop/Program.cs Outdated Show resolved Hide resolved

kiminuo added 2 commits September 21, 2023 10:36

Feedback

4c76178

Merge branch 'master' into feature/2023-09-19-Terminate-application-m…

8bc5d9d

…ove-dispose

wieslawsoltes approved these changes Sep 21, 2023

View reviewed changes

kiminuo merged commit 9e9a2c4 into WalletWasabi:master Sep 21, 2023
3 of 6 checks passed

kiminuo deleted the feature/2023-09-19-Terminate-application-move-dispose branch September 21, 2023 08:42

Provide feedback