Step forward to Remove TransactionSummary (1/n)
#11520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiminuo
commented
Sep 20, 2023
| @@ -17,7 +17,7 @@ public partial class CoinJoinHistoryItemViewModel : HistoryItemViewModelBase | |||
| bool isSingleCoinJoinTransaction) | |||
| : base(orderIndex, transactionSummary) | |||
| { | |||
| Date = transactionSummary.DateTime.ToLocalTime(); | |||
| Date = transactionSummary.FirstSeen.ToLocalTime(); | |||
There was a problem hiding this comment.
SmartTransaction has FirstSeen property, so rename it.
kiminuo
commented
Sep 20, 2023
| @@ -78,4 +79,7 @@ private static IEnumerable<BitcoinAddress> GetDestinationAddresses(ICollection<I | |||
| // All outputs that are not my own are the destinations. | |||
| return foreignOutputs.Select(x => x.DestinationAddress); | |||
| } | |||
|
|
|||
| public static int GetConfirmations(this SmartTransaction transaction, int blockchainTipHeight) | |||
There was a problem hiding this comment.
Extracted from TransactionSummaryExtensions.cs
kiminuo
commented
Sep 20, 2023
| @@ -123,7 +122,7 @@ public static bool NotNullAndNotEmpty<T>(this IEnumerable<T> source) | |||
| } | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Some whitespace from a previous PR.
… original implementation
kiminuo
force-pushed
the
feature/2023-09-20-TransactionSummary-1-n
branch
from
1ee5a02
to
e660115
Compare
adamPetho
approved these changes
Sep 20, 2023
adamPetho
changed the title
TransactionSummary (1/n)TransactionSummary (1/n)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another PR to simplify #11458.
Easy to review commit by commit.