[trivial] Services: Add SmartHeaderChain
#11522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiminuo
changed the title
Services: Add SmartHeaderChainServices: Add SmartHeaderChain
adamPetho
reviewed
Sep 20, 2023
| @@ -24,7 +24,7 @@ public static LabelsArray GetLabels(this SmartCoin coin, int privateThreshold) | |||
| return coin.HdPubKey.Cluster.Labels; | |||
| } | |||
|
|
|||
| public static int GetConfirmations(this SmartCoin coin) => coin.Height.Type == HeightType.Chain ? (int)Services.BitcoinStore.SmartHeaderChain.TipHeight - coin.Height.Value + 1 : 0; | |||
| public static int GetConfirmations(this SmartCoin coin) => coin.Height.Type == HeightType.Chain ? (int)Services.SmartHeaderChain.TipHeight - coin.Height.Value + 1 : 0; | |||
There was a problem hiding this comment.
This whole function feels like a duplicate.
WDYT of this?
public static int GetConfirmations(this SmartCoin coin) => coin.Transaction.GetConfirmations((int)Services.BitcoinStore.SmartHeaderChain.TipHeight);As SmartCoin has its own SmartTransaction, we could use that.
There was a problem hiding this comment.
Oh shit, I forgot that the SmartTransaction.GetConfirmations extension method is not yet on master. 😅
EDIT: If you merge master now, it's there.
There was a problem hiding this comment.
This is a good point. I'll leave it for a follow-up PR but you can create a PR if you like.
# Conflicts: # WalletWasabi.Fluent/Extensions/TransactionSummaryExtensions.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.