Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VDG] Add confirmation time for coinjoins placeholders #11529

Merged

Conversation

SuperJMN
Copy link
Collaborator

@SuperJMN SuperJMN commented Sep 21, 2023

Adds the UI part of confirmation time estimation for coinjoins.

@SuperJMN
Copy link
Collaborator Author

SuperJMN commented Sep 21, 2023

@soosr This is waiting for something similar to what we did for transactions:

TransactionFeeHelper.TryEstimateConfirmationTime(_walletVm.Wallet, transactionSummary.Transaction, out var estimate);

I've added TODO tags to include the actual estimation time calculation when it's available. Please, ping me when the this required implementation is ready :)

@adamPetho
Copy link
Collaborator

I'm on implementing the business logic for this and also for receive tx and payjoins etc (for all txs which has foreign input). WIP.

@soosr soosr marked this pull request as ready for review September 25, 2023 07:17
Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK.

Edited the description so I removed the "Fixes" keyword, it's going to be fixed when @adamPetho implements the business part.

@soosr soosr merged commit 098cb9f into WalletWasabi:master Sep 25, 2023
7 checks passed
@SuperJMN SuperJMN deleted the features/11449-add-cj-confirmationtime branch October 2, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants