Add canceltransaction RPC method
#11536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
kiminuo
reviewed
Sep 23, 2023
| var mempoolStore = Global.BitcoinStore.TransactionStore.MempoolStore; | ||
| if (!mempoolStore.TryGetTransaction(txId, out var smartTransactionToCancel)) | ||
| { | ||
| throw new NotSupportedException($"Unknown transaction {txId}"); |
There was a problem hiding this comment.
nit: Would ArgumentException be better? Or does throwing NotSupportedException lead to some interesting behavior?
There was a problem hiding this comment.
It could be. There is another issue to fix the error reporting code. I still don't know exactly how but I will take this there.
kiminuo
reviewed
Sep 23, 2023
| @@ -220,6 +220,23 @@ public async Task<object> SendTransactionAsync(PaymentInfo[] payments, OutPoint[ | |||
| }; | |||
| } | |||
|
|
|||
| [JsonRpcMethod("canceltransaction")] | |||
| public string BuildCancelTransaction(uint256 txId, string password = "") | |||
There was a problem hiding this comment.
(note to self: This somewhat makes it look like we succeed in case the parameters are correct but it might still fail because the cancellation would be too expensive AFAIK. Not sure how expected that is but hopefully we will document it in the RPC documentation)
lontivero
force-pushed
the
speedup-rpc
branch
from
937e649
to
adad158
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
canceltransactionRPC method which received the hash of the transaction to be cancelled and returns the raw transaction that cancels the previous tx.This one and #11537 close: #11500