Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VDG] Fix for projections of lists that have no items #11548

Merged
merged 5 commits into from
Sep 25, 2023

Conversation

SuperJMN
Copy link
Collaborator

When the initial list of items has no elements, there's no change at all.

Empty should be signaled.

Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does fix the missing percentage number for an empty wallet, but it breaks the coin control:
image

@SuperJMN
Copy link
Collaborator Author

It does fix the missing percentage number for an empty wallet, but it breaks the coin control: image

I'll take a look. It should't have broken anything 🤨

Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@soosr soosr merged commit 8afd60f into WalletWasabi:master Sep 25, 2023
7 checks passed
@soosr soosr mentioned this pull request Sep 25, 2023
@SuperJMN SuperJMN deleted the fixes/fix-zero-item-changesets branch October 2, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants