Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up transaction processing by 20% #11555

Merged
merged 3 commits into from
Sep 23, 2023

Conversation

nopara73
Copy link
Contributor

This PR optimizes out section B bottleneck (described here: #11287) of transaction processing with no noticeable memory growth.

This PR is a part of #11298 and #11513

master:

1.6GB memory
2023-09-23 10:51:43.331 [17] INFO	Wallet.Dispose (421)	Initial Transaction Processing finished in 9.2 seconds.
Time spent in sections: A: 0.42%, B: 24.02%, C: 1.40%, D: 28.57%, E: 7.25%, F: 1.05%, G: 37.28%

This PR:

1.6 GB memory
2023-09-23 10:57:18.962 [20] INFO	Wallet.Dispose (421)	Initial Transaction Processing finished in 8.32 seconds.
2023-09-23 10:58:58.438 [17] INFO	Wallet.Dispose (421)	Initial Transaction Processing finished in 8.71 seconds.
2023-09-23 11:01:29.075 [28] INFO	Wallet.Dispose (421)	Initial Transaction Processing finished in 9.14 seconds.
2023-09-23 11:06:51.018 [9] INFO	Wallet.Dispose (421)	Initial Transaction Processing finished in 7.53 seconds.
Time spent in sections: A: 0.51%, B: 0.04%, C: 1.52%, D: 43.38%, E: 8.36%, F: 1.01%, G: 45.19%

@nopara73
Copy link
Contributor Author

If tests pass (regtests included) I merge.

Copy link
Collaborator

@turbolay turbolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK
This change is the most trivial part of #11298, I see no risk of merging it.
It's also part of #11516.

If tests pass (regtests included) I merge.

Sorry not fast enough, I had time to review 😆

@pull-request-size pull-request-size bot added size/M and removed size/S labels Sep 23, 2023
@nopara73 nopara73 merged commit 05c946d into WalletWasabi:master Sep 23, 2023
7 checks passed
@nopara73 nopara73 deleted the 1695437778 branch September 24, 2023 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants