TransactionBroadcaster: Minor cleanup
#11591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… implementation)
kiminuo
commented
Sep 27, 2023
| /// Implements method that behaves as <see cref="Task.WaitAsync(TimeSpan)"/> but | ||
| /// it throws <see cref="OperationCanceledException"/> instead of <see cref="TimeoutException"/>. | ||
| /// </summary> | ||
| public static async Task WithAwaitCancellationAsync(this Task task, TimeSpan timeout) |
There was a problem hiding this comment.
Unused at this point. New use is discouraged because .NET has WaitAsync.
kiminuo
commented
Sep 27, 2023
| @@ -52,7 +52,7 @@ private async Task BroadcastTransactionToNetworkNodeAsync(SmartTransaction trans | |||
| var invPayload = new InvPayload(transaction.Transaction); | |||
|
|
|||
| // Give 7 seconds to send the inv payload. | |||
| await node.SendMessageAsync(invPayload).WithAwaitCancellationAsync(TimeSpan.FromSeconds(7)).ConfigureAwait(false); // ToDo: It's dangerous way to cancel. Implement proper cancellation to NBitcoin! | |||
| await node.SendMessageAsync(invPayload).WaitAsync(TimeSpan.FromSeconds(7)).ConfigureAwait(false); // ToDo: It's dangerous way to cancel. Implement proper cancellation to NBitcoin! | |||
There was a problem hiding this comment.
This change is safe because there is only one caller or the enclosing method and we catch any exception there.
adamPetho
previously approved these changes
Sep 29, 2023
WalletWasabi/Blockchain/TransactionBroadcasting/TransactionBroadcaster.cs
Outdated
Show resolved
Hide resolved
…adcaster.cs Co-authored-by: adamPetho <45069029+adamPetho@users.noreply.github.com>
adamPetho
approved these changes
Sep 29, 2023
kiminuo
deleted the
feature/2023-09-27-TransactionBroadcaster-minor-cleanup
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while researching TransactionSummary removal.