[VDG] Temporarily disabling the running in background on macOS #11595
Conversation
There was a problem hiding this comment.
I am wondering about the backward compatibility... what will happen with those users who had the Start in the background feature enabled by default?
ApplicationStateManager L35, the initial state will be closed so the client will just close immediately? (I don't have mac, cannot test it)
Yes, I tested to enable the feature on master, then checkout and run this PR, and it was disabled. Then checkout back master and the feature was enabled again. But because you mentioned it, I tried the other way around. Disable on master, go to the PR, and go back on master. Back on master, feature activates itself, even if it was not enabled in the first place. So this might be an UX issue: Users willingly disabled the feature but then out of a sudden it gots reactivated. We can also see it as a nice way to notify them in the future that the feature is fixed. |
I guess when we reenable the future we should handle that scenario on the first run. |
WalletWasabi.Fluent/App.axaml.cs
Outdated
| @@ -20,6 +21,14 @@ public class App : Application | |||
| private readonly Func<Task>? _backendInitialiseAsync; | |||
| private ApplicationStateManager? _applicationStateManager; | |||
|
|
|||
| public static bool EnableFeatureHideOnClose { get; private set; } | |||
There was a problem hiding this comment.
I think this name should be EnableFeatureHide because it should affect every hide related thing, and not just the HideOnClose
There was a problem hiding this comment.
pushed changes
@soosr this one is tricky as it does not have IsVisible property |
|
@wieslawsoltes Could you fix CF? |
@soosr I already fixed, CF has wrong commit |
Temporary fix until we can #8151 available in Avalonia.
Based on comment: #8151 (comment)
Add static property in App class called EnableFeatureHideOnClose to disable HideOnClose functionality (from UI and app state manager).