CoinsRegistry: Optimize GetMyInputs
#11618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiminuo
force-pushed
the
feature/2023-10-02-CoinsRegistry-optimize-GetMyInputs
branch
from
97b18cb
to
2482edc
Compare
kiminuo
commented
Oct 2, 2023
| @@ -278,16 +278,15 @@ public bool TryGetSpentCoinByOutPoint(OutPoint outPoint, [NotNullWhen(true)] out | |||
| } | |||
| } | |||
|
|
|||
| public IEnumerable<SmartCoin> GetMyInputs(SmartTransaction transaction) | |||
| public IReadOnlyList<SmartCoin> GetMyInputs(SmartTransaction transaction) | |||
There was a problem hiding this comment.
IReadOnlyList implements IEnumerable and notably it allows us to work with the result efficiently.
kiminuo
commented
Oct 2, 2023
| { | ||
| var inputs = transaction.Transaction.Inputs.Select(x => x.PrevOut).ToArray(); |
There was a problem hiding this comment.
Removes needless allocations.
kiminuo
deleted the
feature/2023-10-02-CoinsRegistry-optimize-GetMyInputs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.