Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vdg] clarify Transaction Broadcaster dialog caption #11634

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

MarnixCroes
Copy link
Collaborator

current
image

over time, several people reached out that they were not able to paste their tx.
It turned out that they were pasting the TxID instead of the hex.

so just a small clarification.

shouldn't be controversial that hex is technical as this is for advanced usage anyway.

@soosr
Copy link
Collaborator

soosr commented Oct 4, 2023

Does it work with raw transactions or PSBTs?

@MarnixCroes
Copy link
Collaborator Author

Does it work with raw transactions or PSBTs?

a raw transaction is (usually) hex encoded right.
about PSBT, good point. afaik it's possible to paste base64 PSBT.

WDYT, could it be improved or close the PR?

@turbolay
Copy link
Collaborator

turbolay commented Oct 4, 2023

transaction data ?

@soosr
Copy link
Collaborator

soosr commented Oct 4, 2023

Does it work with raw transactions or PSBTs?

a raw transaction is (usually) hex encoded right. about PSBT, good point. afaik it's possible to paste base64 PSBT.

WDYT, could it be improved or close the PR?

just making it accurate what transactions it works with.
Because now it says Import or paste the transaction hex so I was wondering if it is 100% accurate or true in every case.

@MarnixCroes
Copy link
Collaborator Author

@turbolay thanks for the suggestion. I'm not sure that transaction data is easier to understand tbh, it might be confusing: "What data do I need to paste?"

Maybe current one is as good as it gets and the improvement could be in the error dialog when txid was pasted

@soosr soosr merged commit 14a48fd into WalletWasabi:master Oct 5, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants