Wallet rename

[SuperJMN]

This PR allows renaming a wallet by going into Wallet Settings

WalletWasabi.Fluent.Desktop_qgvbjQVA2c.mp4

I'm trying to keep things as simple as I can with this.
Will require thorough testing.

Closes #3527

[turbolay]

I had an idea while reading the code, I'm sharing as maybe it's interesting (maybe it isn't):

Instead of introducing Id/Name as you are doing, we could validate the new name in the UI and schedule the execution of a batch script after the software's termination that will rename the file directly in the OS. We display to the user, "The wallet will be renamed next time you'll relaunch the app".

It's obviously a hacky solution, but it avoids changing the reliance on the name as an ID (which maybe is not even good in the first place soo....)

[MarnixCroes]

the Rename button is still clickable while it is not visible

[soosr]

Backup

Taking a look at the backup logic, it doesn't care if there is already a different wallet with the same file name. It just overrides it.
So when the user renames a wallet, you can simply rename the corresponding file in the backup directory (if there is any).

https://github.com/zkSNACKs/WalletWasabi/blob/7325103413d7db5fb8d4bd444d806ccfae062f49/WalletWasabi/Wallets/WalletManager.cs#L313-L321

UX

I think we should introduce a separate dialog for renaming the wallet. Similar to how the user can edit the label of an address. With this you could validate the input and only enable the Continue button, when the name is valid, also the user would still have the opportunity the cancel the operation in a friendlier way.

So in settings:

Wallet name             [Rename]

Which would pop a compact dialog.

[MarnixCroes]

fwiw: I just also tested the RPC with this PR, works fine.
also tested renaming in the GUI and after that the RPC only recognizes the new wallet name

[yahiheb]

This doesn't work for me on Win10.

[SuperJMN]

This doesn't work for me on Win10.

Thanks for the heads up @yahiheb ! Should work now :)

[molnard]

tACK

• Renaming multiple wallets.
• Renaming during CJ critical phase.
• Same name not allowed.
• Special characters.

[MarnixCroes]

tack 7765369 could not break it.

two nits:

• In the UI, why the large spacing between Name and the rename button?
• normally when launching Wasabi it will automatically select the latest used wallet. It doesn't do that when having renamed the wallet. I guess that's ok.

[soosr]

In the UI, why the large spacing between Name and the rename button?

That is the standard layout. Title to the left, actions buttons to the right. It will align better when more setting is added (like it is in the app settings).

normally when launching Wasabi it will automatically select the latest used wallet. It doesn't do that when having renamed the wallet. I guess that's ok.

Bug. #12253

[yahiheb]

That is the standard layout. Title to the left, actions buttons to the right.

The rename button is neither to the right nor in the middle.