Refactor of TryAdd method

[M1nd3r]

Hi, I am new on this project and I am not sure about the "right" process. I just saw a multiple-level nested if statements in a code I was trying to read. Thus, I have decided to refactor the code to improve readability (extract one method into four).

If extraction of methods is less preferable to nested if blocks, feel free to disregard/close this pull request.

Thanks for any feedback

[lontivero]

Improving the quality of the code is always welcome and avoiding nesting is something that generally speaking improves the quality of the code by making it more readable. Readability is the goal, removing nesting is just one way to achieve that.

In this case the elimination of the nested blocks doesn't improves the readability but it make it worse instead. It is impossible to me at least to understand what the method does after this refactoring because of the empty semantic of
InitializeSmartCoinDataNoLock and UpdateCoinMappingsNoLock. It is for that that in order to understand what is going on I am forced to jump to those methods and then jump back to continue reading the method code.

[M1nd3r]

Ok, I see what you mean @lontivero . I dialed the extraction down - the level of nesting is still reduced by two compared to the original.

Do you think this approach is ok?

[lontivero]

I think so, yes.

[yahiheb]

LGTM

[kiminuo]

LGTM

I would just do the following modification: https://github.com/zkSNACKs/WalletWasabi/pull/11687/files?diff=split&w=1#r1359933660

[yahiheb]

LGTM

[kiminuo]

@M1nd3r Thanks