[VDG] Add colorful diffs in Transaction Preview

[SuperJMN]

This adds colored hints to the changing items when hovering over a suggestion, in the Transaction Preview. It helps users identify what they're getting applying a given suggestion.

Closes #11039

[MarnixCroes]

The amount percentage difference is inverse?
both amount and fee
e.g. have a fee of 221 sats, hover over change avoidance, fee becomes 110 sats. It says the difference is 100.91%
It should be ~ -50%

[SuperJMN]

The amount percentage difference is inverse? both amount and fee e.g. have a fee of 221 sats, hover over change avoidance, fee becomes 110 sats. It says the difference is 100.91% It should be ~ -50%

Mmm, let me review the calculation. I did some last time changes that could be wrong.

[SuperJMN]

-50%

Yes, it was exactly the opposite. Good catch. Thank you! Please check if it works now.

[MarnixCroes]

why use NeutralDiffConverter at amount and InvertedDiffConverter at fee? in the TransactionSummary view

In the GUI, at Amount, the brush is currently always orange, both for positive and negative difference

[MarnixCroes]

ZeroBrush and NegativeBrush shouldn't be the same color right?

[SuperJMN]

They can be, because in fact, there's no negative color defined in the specs. Should we define one? @soosr

[soosr]

Just have a PositiveBrush and a UncertainBrush. Later if we need a negative brush, we can add one.

[SuperJMN]

why use NeutralDiffConverter at amount and InvertedDiffConverter at fee? in the TransactionSummary view

In the GUI, at Amount, the brush is currently always orange, both for positive and negative difference

For amount it's the same because we can't decide if it's good or bad. For fees, we can :)

[MarnixCroes]

why use NeutralDiffConverter at amount and InvertedDiffConverter at fee? in the TransactionSummary view

In the GUI, at Amount, the brush is currently always orange, both for positive and negative difference

For amount it's the same because we can't decide if it's good or bad. For fees, we can :)

I'd say to give it a neutral color then?

[soosr]

why use NeutralDiffConverter at amount and InvertedDiffConverter at fee? in the TransactionSummary view
In the GUI, at Amount, the brush is currently always orange, both for positive and negative difference

For amount it's the same because we can't decide if it's good or bad. For fees, we can :)

I'd say to give it a neutral color then?

Orange is the warning color it doesn't mean bad or good it just wants to get attention. For Example in settings when restart is needed.
(It might be wrongly used elsewhere, but here it is correct)

[soosr]

@SuperJMN Fix conflicts, please.

[MarnixCroes]

why use NeutralDiffConverter at amount and InvertedDiffConverter at fee? in the TransactionSummary view
In the GUI, at Amount, the brush is currently always orange, both for positive and negative difference

For amount it's the same because we can't decide if it's good or bad. For fees, we can :)

I'd say to give it a neutral color then?

Orange is the warning color it doesn't mean bad or good it just wants to get attention. For Example in settings when restart is needed. (It might be wrongly used elsewhere, but here it is correct)

ok. for me the confusing part is that at Fee the orange (diff) is bad, but at Amount it doesn't mean "bad"

[soosr]

why use NeutralDiffConverter at amount and InvertedDiffConverter at fee? in the TransactionSummary view
In the GUI, at Amount, the brush is currently always orange, both for positive and negative difference

For amount it's the same because we can't decide if it's good or bad. For fees, we can :)

I'd say to give it a neutral color then?

Orange is the warning color it doesn't mean bad or good it just wants to get attention. For Example in settings when restart is needed. (It might be wrongly used elsewhere, but here it is correct)

ok. for me the confusing part is that at Fee the orange (diff) is bad, but at Amount it doesn't mean "bad"

The rationale behind this is to reward to good rather than punish the bad thing. Which is followed software-wide. Although I see your point, during the UI Refreshment I will remember this.

[soosr]

@SuperJMN Could you fix the conflict?

[soosr]

Can you add conditional formatting here? Similarly what you did with USD amounts

[soosr]

Can you me this 0.2?

BTW the percentage seems to be wrong, I think the number should be multiplied by 100 in order to get a percentage.

[SuperJMN]

Can you me this 0.2?
BTW the percentage seems to be wrong, I think the number should be multiplied by 100 in order to get a percentage.

Fixed! Thanks for reporting!

[soosr]

tACK