Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VDG] Fix LabelsItemsPresenter layout algorithm after update to Avalonia 11 #11733

Merged
merged 8 commits into from
Oct 21, 2023
Merged

[VDG] Fix LabelsItemsPresenter layout algorithm after update to Avalonia 11 #11733

merged 8 commits into from
Oct 21, 2023

Conversation

wieslawsoltes
Copy link
Collaborator

@wieslawsoltes wieslawsoltes commented Oct 18, 2023 •
edited

Fixes: #11724
Fixes: #11742

image

image

@wieslawsoltes wieslawsoltes mentioned this pull request Oct 19, 2023
Closed
MarnixCroes
MarnixCroes reviewed Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@MarnixCroes MarnixCroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes #11724
can still repro #11742

@wieslawsoltes
Copy link
Collaborator Author

fixes #11724 can still repro #11742

I just had quick try to workaround but the issue is bit more complex

@wieslawsoltes wieslawsoltes changed the title Fix LabelsItemsPresenter [VDG] Fix LabelsItemsPresenter Oct 19, 2023
@wieslawsoltes wieslawsoltes changed the title [VDG] Fix LabelsItemsPresenter [VDG] Fix LabelsItemsPresenter layout algorithm after update to Avalonia 11 Oct 20, 2023
@pull-request-size pull-request-size bot added size/L and removed size/S labels Oct 20, 2023
@wieslawsoltes wieslawsoltes marked this pull request as ready for review October 21, 2023 11:49
MarnixCroes
MarnixCroes approved these changes Oct 21, 2023
View reviewed changes
Copy link
Collaborator

@MarnixCroes MarnixCroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tack 56cc298

soosr
soosr previously approved these changes Oct 21, 2023
View reviewed changes
Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@soosr soosr merged commit 1155a0a into WalletWasabi:master Oct 21, 2023
2 of 6 checks passed
@wieslawsoltes wieslawsoltes mentioned this pull request Oct 22, 2023
Open
29 tasks
@wieslawsoltes wieslawsoltes deleted the vdg/fixes/LabelsItemsPresenterMeasure branch October 25, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soosr soosr soosr approved these changes

@MarnixCroes MarnixCroes MarnixCroes approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
3 participants
@wieslawsoltes @soosr @MarnixCroes