TransactionFactory: Introduce TransactionParameters
#11738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiminuo
commented
Oct 18, 2023
| @@ -48,10 +48,22 @@ public TransactionFactory(Network network, KeyManager keyManager, ICoinsView coi | |||
| IEnumerable<OutPoint>? allowedInputs = null, | |||
| IPayjoinClient? payjoinClient = null, | |||
| Func<LockTime>? lockTimeSelector = null, | |||
| bool allowUnconfirmed = true, | |||
There was a problem hiding this comment.
Note that this method is called only from tests.
kiminuo
force-pushed
the
feature/2023-10-18-TransactionParameters
branch
from
f0ea40a
to
bb329e3
Compare
kiminuo
commented
Oct 19, 2023
| @@ -65,15 +65,20 @@ public static BuildTransactionResult BuildTransaction(Wallet wallet, Transaction | |||
| label: transactionInfo.Recipient); | |||
|
|
|||
| var network = keyManager.GetNetwork(); | |||
| var builder = new TransactionFactory(network, keyManager, allCoins, new EmptyTransactionStore(network), password, true); | |||
| var builder = new TransactionFactory(network, keyManager, allCoins, new EmptyTransactionStore(network), password); | |||
There was a problem hiding this comment.
true -> L73 AllowUnconfirmed: true
Co-authored-by: Szpoti <balage.farago@gmail.com>
kiminuo
force-pushed
the
feature/2023-10-18-TransactionParameters
branch
from
bb329e3
to
fa6f46e
Compare
Szpoti
approved these changes
Oct 19, 2023
adamPetho
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #11737
Refactored #11709 (credits to Szpoti).
Note: This PR intentionally attempts not to modify tests.